Accounting for joint scale in gltf importer#63
Open
metaremi wants to merge 1 commit intoadobe:mainfrom
Open
Conversation
This fixes the glTF skeleton joint transform import to properly account for joint scale. The previous code only considered translation and rotation when building the rest transforms for skeleton joints. The updated code: 1. **Handles direct matrix data**: First checks if the node has a complete 4x4 matrix specified (via `node.matrix`) and uses it directly 2. **Includes scale**: When building from individual components (translation, rotation, scale), now properly extracts and applies the scale values 3. **Proper composition**: Constructs the final 4x4 transform matrix by scaling the rotation matrix and then adding translation, preserving the correct order of transformations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the glTF skeleton joint transform import to properly account for joint scale. The previous code only considered translation and rotation when building the rest transforms for skeleton joints. The updated code:
Description
node.matrix) and uses it directlyRelated Issue
Motivation and Context
fixes import of scale transform
How Has This Been Tested?
tested glTF are correctly imported
Screenshots (if appropriate):
Types of changes
Checklist: